Conversation
Contributor
Author
|
Thanks to the failed r-test I realized that one condition is not properly handled at the moment. The failed test From here, we would expect to write VTK outputs at: 0, 1, 2. However, the results at the last step are skipped. The proposed final step catch-up logic was failing when the last I updated the logic in commit 0873538. For reference, I attach the expected behavior below:
|
RBergua
marked this pull request as ready for review
September 26, 2026 12:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
In the OLAF output section, the
WrVTKflag lets the user control visualization output:0: NoVTK1: Write VTK at each time step defined byVTK_fps2: Write VTK at the beginning and end of the simulationSeparately, grid outputs (
nGridOut) are controlled independently, with each grid defining its ownTStart,TEnd, andDTOut.Problems fixed:
1. Setting
WrVTK > 0forced every grid output to write at the last step, even though grid outputs should only follow their own schedule (TStart/TEnd/DTOut), independent of the wake's final write logic.2. Setting
WrVTK = 1incorrectly forced an extra output at the final step, even though onlyWrVTK = 2should include a start/end write.Changes:
1. Grid outputs (
nGridOut) are now written only according to their own schedule, independent from the wakeWrVTKflag.2.
WrVTK = 1no longer forces an output at the final step.